refactor: load module content an owned value#154
Open
lucacasonato wants to merge 4 commits intodenoland:mainfrom
Open
refactor: load module content an owned value#154lucacasonato wants to merge 4 commits intodenoland:mainfrom
lucacasonato wants to merge 4 commits intodenoland:mainfrom
Conversation
lucacasonato
force-pushed
the
load_owned_value
branch
from
d114bb3 to
6691015
Compare
Previously, if a specifier was imported more than once, with conflicting assertions, we'd only really consider the final import. This is wrong: conflicting assertions are an error in-themselves already. I think this behaviour is still wrong, because if a module is imported with incorrect assertions later in the graph after the module has already been loaded by an import with a correct assertion, no error will be raised.
This is a pre-requisite for WASM imports that additionally allows us to minimize clones when doing things like BOM stripping.
lucacasonato
force-pushed
the
load_owned_value
branch
from
6691015 to
024c08e
Compare
dsherret
reviewed
May 30, 2022
Member
dsherret
left a comment
dsherret
left a comment
There was a problem hiding this comment.
LGTM, but let's open downstream draft PRs before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite for WASM imports that additionally allows us to
minimize clones when doing things like BOM stripping.